From dev-return-19008-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Thu Aug 23 01:52:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4C537180662 for ; Thu, 23 Aug 2018 01:52:32 +0200 (CEST) Received: (qmail 9069 invoked by uid 500); 22 Aug 2018 23:52:31 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 9058 invoked by uid 99); 22 Aug 2018 23:52:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 23:52:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 50D33C0115; Wed, 22 Aug 2018 23:52:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.701 X-Spam-Level: X-Spam-Status: No, score=0.701 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 1rUKHV09hszm; Wed, 22 Aug 2018 23:52:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 942DA5F3BE; Wed, 22 Aug 2018 23:52:28 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EDE37E0101; Wed, 22 Aug 2018 23:52:27 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DA0F5C4006E; Wed, 22 Aug 2018 23:52:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5411568245413561186==" MIME-Version: 1.0 Subject: Review Request 68480: RANGER-2196: Ensure that any explicit threads used by Ranger are marked as daemon threads From: Abhay Kulkarni To: Velmurugan Periasamy , Madhan Neethiraj Cc: Abhay Kulkarni , ranger Date: Wed, 22 Aug 2018 23:52:27 -0000 Message-ID: <20180822235227.5558.71505@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Abhay Kulkarni X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68480/ X-Sender: Abhay Kulkarni Reply-To: Abhay Kulkarni X-ReviewRequest-Repository: ranger --===============5411568245413561186== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68480/ ----------------------------------------------------------- Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. Bugs: RANGER-2196 https://issues.apache.org/jira/browse/RANGER-2196 Repository: ranger Description ------- Non-daemon threads may cause ranger-admin process to wait until all such threads terminate even when main() terminates. This may cause ranger-admin to appear to be hanging and may trigger restart from any monitoring system. Diffs ----- agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 8a14394fc agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java f1b97643b agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java 9c7c775c3 security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java efbdfdf7f security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java e5e957208 unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 45834f49d Diff: https://reviews.apache.org/r/68480/diff/1/ Testing ------- Passed all unit tests Thanks, Abhay Kulkarni --===============5411568245413561186==--