From dev-return-18965-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Fri Aug 17 12:56:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 63A2618067A for ; Fri, 17 Aug 2018 12:56:00 +0200 (CEST) Received: (qmail 38565 invoked by uid 500); 17 Aug 2018 10:55:59 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 38549 invoked by uid 99); 17 Aug 2018 10:55:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Aug 2018 10:55:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 664AD1805C4; Fri, 17 Aug 2018 10:55:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.902 X-Spam-Level: * X-Spam-Status: No, score=1.902 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id C4zwoVfjJb-v; Fri, 17 Aug 2018 10:55:57 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1058C5F300; Fri, 17 Aug 2018 10:55:57 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AB833E0177; Fri, 17 Aug 2018 10:55:56 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 76B55C400E0; Fri, 17 Aug 2018 10:55:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8830394806836932368==" MIME-Version: 1.0 Subject: Re: Review Request 68211: RANGER-2157 Add NiFi Registry service definition and NiFiRegistryClient From: "ijokarumawak@gmail.com Koji" To: "ijokarumawak@gmail.com Koji" , Ramesh Mani , ranger Date: Fri, 17 Aug 2018 10:55:56 -0000 Message-ID: <20180817105556.27877.1170@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "ijokarumawak@gmail.com Koji" X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68211/ X-Sender: "ijokarumawak@gmail.com Koji" References: <20180809022728.40597.18462@reviews-vm2.apache.org> In-Reply-To: <20180809022728.40597.18462@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java X-ReviewBoard-Diff-For: plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java X-ReviewBoard-Diff-For: plugin-nifi-registry/pom.xml X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java X-ReviewBoard-Diff-For: plugin-nifi-registry/.gitignore X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java X-ReviewBoard-Diff-For: agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json X-ReviewBoard-Diff-For: plugin-nifi-registry/src/test/resources/resources-response.json X-ReviewBoard-Diff-For: plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java X-ReviewBoard-Diff-For: plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java Reply-To: "ijokarumawak@gmail.com Koji" X-ReviewRequest-Repository: ranger --===============8830394806836932368== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68211/ ----------------------------------------------------------- (Updated Aug. 17, 2018, 10:55 a.m.) Review request for ranger. Changes ------- Changed service id from 12 to 13 since 12 has been already taken by Kylin. Bugs: RANGER-2157 https://issues.apache.org/jira/browse/RANGER-2157 Repository: ranger Description ------- Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi. Diffs (updated) ----- agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION plugin-nifi-registry/.gitignore PRE-CREATION plugin-nifi-registry/pom.xml PRE-CREATION plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION pom.xml 472199d5d src/main/assembly/admin-web.xml d0f354520 Diff: https://reviews.apache.org/r/68211/diff/3/ Changes: https://reviews.apache.org/r/68211/diff/2-3/ Testing ------- Tested on local machine. In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point. Thanks, ijokarumawak@gmail.com Koji --===============8830394806836932368==--