From dev-return-18857-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Wed Aug 8 06:56:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 297FB180600 for ; Wed, 8 Aug 2018 06:56:53 +0200 (CEST) Received: (qmail 29831 invoked by uid 500); 8 Aug 2018 04:56:52 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 29394 invoked by uid 99); 8 Aug 2018 04:56:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2018 04:56:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D7C2DC1D85; Wed, 8 Aug 2018 04:56:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.15 X-Spam-Level: * X-Spam-Status: No, score=1.15 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id RzvnsY_MfQi7; Wed, 8 Aug 2018 04:56:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EE96E5F3CD; Wed, 8 Aug 2018 04:56:48 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0B83DE0026; Wed, 8 Aug 2018 04:56:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 96045C4013E; Wed, 8 Aug 2018 04:56:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0566982079180438864==" MIME-Version: 1.0 Subject: Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices From: Abhay Kulkarni To: Gautam Borad , Mehul Parikh , Ramesh Mani , Velmurugan Periasamy , Pradeep Agrawal , Selvamohan Neethiraj , Ankita Sinha , Madhan Neethiraj , Abhay Kulkarni Cc: bhavik patel , ranger Date: Wed, 08 Aug 2018 04:56:47 -0000 Message-ID: <20180808045647.33403.82046@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Abhay Kulkarni X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68186/ X-Sender: Abhay Kulkarni X-ReviewBoard-ShipIt: 1 References: <20180807132153.33402.51232@reviews-vm2.apache.org> In-Reply-To: <20180807132153.33402.51232@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Abhay Kulkarni X-ReviewRequest-Repository: ranger --===============0566982079180438864== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206968 ----------------------------------------------------------- Ship it! Ship It! - Abhay Kulkarni On Aug. 7, 2018, 1:21 p.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68186/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2018, 1:21 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-2181 > https://issues.apache.org/jira/browse/RANGER-2181 > > > Repository: ranger > > > Description > ------- > > Code Improvement To Follow Best Practices. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java 41052dd > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java 1893fb9 > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceValidator.java 64ccb7d > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c116ea2 > security-admin/src/main/webapp/scripts/models/RangerServiceDef.js 9945044 > security-admin/src/main/webapp/styles/xa.css db96ed2 > security-admin/src/main/webapp/templates/helpers/XAHelpers.js 8ace4d7 > > > Diff: https://reviews.apache.org/r/68186/diff/3/ > > > Testing > ------- > > 1. Tested Ranger Admin & Ranger KMS rest calls. > > > Thanks, > > bhavik patel > > --===============0566982079180438864==--