From dev-return-18772-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Wed Aug 1 11:07:20 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C9C68180634 for ; Wed, 1 Aug 2018 11:07:19 +0200 (CEST) Received: (qmail 1290 invoked by uid 500); 1 Aug 2018 09:07:19 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 1279 invoked by uid 99); 1 Aug 2018 09:07:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2018 09:07:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CFC49C84AE; Wed, 1 Aug 2018 09:07:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.102 X-Spam-Level: ** X-Spam-Status: No, score=2.102 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id RmoaFU1jTW_4; Wed, 1 Aug 2018 09:07:17 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AE2615F30C; Wed, 1 Aug 2018 09:07:16 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4E535E0289; Wed, 1 Aug 2018 09:07:16 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 37845C40222; Wed, 1 Aug 2018 09:07:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0856453563058813626==" MIME-Version: 1.0 Subject: Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version. From: Nitin Galave To: Gautam Borad , Venkat Ranganathan , pengjianhua , Ramesh Mani , Velmurugan Periasamy , sam rome , Colm O hEigeartaigh , Selvamohan Neethiraj , Ankita Sinha , Madhan Neethiraj , Don Bosco Durai Cc: Nitin Galave , Qiang Zhang , ranger Date: Wed, 01 Aug 2018 09:07:16 -0000 Message-ID: <20180801090716.53841.80155@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nitin Galave X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68010/ X-Sender: Nitin Galave References: <20180727064526.7775.78323@reviews-vm2.apache.org> In-Reply-To: <20180727064526.7775.78323@reviews-vm2.apache.org> Reply-To: Nitin Galave X-ReviewRequest-Repository: ranger --===============0856453563058813626== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68010/#review206733 ----------------------------------------------------------- security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js Lines 300 (patched) Why are we reloading the page here? any specific reason if reloading page is for getting the newly updated collection for policies then we should manually get updated collection(policies) by using backbone's collection.fetch method. We should avoid such action(reload) in single page application (SPA) - Nitin Galave On July 27, 2018, 6:45 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68010/ > ----------------------------------------------------------- > > (Updated July 27, 2018, 6:45 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy. > > > Bugs: RANGER-2153 > https://issues.apache.org/jira/browse/RANGER-2153 > > > Repository: ranger > > > Description > ------- > > Supply the function of reverting policy history version. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js a0b46fdf6 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 206bb96ac > > > Diff: https://reviews.apache.org/r/68010/diff/2/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > > --===============0856453563058813626==--