ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 68177: RANGER-2188: Support multiple threads to build Trie and on-lookup post-setup for Trie nodes
Date Tue, 14 Aug 2018 17:12:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68177/
-----------------------------------------------------------

(Updated Aug. 14, 2018, 5:12 p.m.)


Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.


Changes
-------

Addressed review comment


Bugs: RANGER-2188
    https://issues.apache.org/jira/browse/RANGER-2188


Repository: ranger


Description
-------

Time for building a Trie index for resources may become a bottleneck when dealing with large
number of resources. It is desirable to build different, non-overlapping parts of Trie structure
using multiple threads to reduce overall build time if configured to do so.

Also, instead of building out all Trie nodes completely (that is, by propagating wildcard
evaluators all the way to all leaves of Trie tree) at the initialization time, it is optimal
to do so as a Trie-Node is accessed for the first time during resource lookup.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
b12d8ff11 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java
b76820cd2 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
088b729fb 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java 10c6faa92

  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
1d9b865b0 


Diff: https://reviews.apache.org/r/68177/diff/5/

Changes: https://reviews.apache.org/r/68177/diff/4-5/


Testing
-------

Passes all unit tests


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message