ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehul Parikh <mehul.par...@freestoneinfotech.com>
Subject Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices
Date Wed, 08 Aug 2018 05:18:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68186/#review206969
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Aug. 7, 2018, 1:21 p.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68186/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 1:21 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2181
>     https://issues.apache.org/jira/browse/RANGER-2181
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Code Improvement To Follow Best Practices.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java
41052dd 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java
1893fb9 
>   agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceValidator.java
64ccb7d 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c116ea2 
>   security-admin/src/main/webapp/scripts/models/RangerServiceDef.js 9945044 
>   security-admin/src/main/webapp/styles/xa.css db96ed2 
>   security-admin/src/main/webapp/templates/helpers/XAHelpers.js 8ace4d7 
> 
> 
> Diff: https://reviews.apache.org/r/68186/diff/3/
> 
> 
> Testing
> -------
> 
> 1. Tested Ranger Admin & Ranger KMS rest calls.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message