ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 68228: Unit Test cases to cover policy operations from service admin user
Date Tue, 07 Aug 2018 13:31:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68228/#review206944
-----------------------------------------------------------




security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java
Lines 1046 (patched)
<https://reviews.apache.org/r/68228/#comment290122>

    Can you fix the PMD error? This is breaking the build? 
    
    ```
    [INFO] --- maven-pmd-plugin:3.7:check (default) @ security-admin-web ---
    [INFO] PMD Failure: org.apache.ranger.rest.TestServiceREST:1046 Rule:UnusedLocalVariable
Priority:3 Avoid unused local variables such as 'rs'..
    ```


- Velmurugan Periasamy


On Aug. 7, 2018, 7:26 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68228/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 7:26 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2171
>     https://issues.apache.org/jira/browse/RANGER-2171
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Unit Test cases to cover policy operations from service admin user(RANGER-2168)
> 
> 
> Diffs
> -----
> 
>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b0110

>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java e669c03 
> 
> 
> Diff: https://reviews.apache.org/r/68228/diff/2/
> 
> 
> Testing
> -------
> 
> Tested if unit test cases are running fine on local.
> 
> 
> File Attachments
> ----------------
> 
> RANGER-2171_2.patch
>   https://reviews.apache.org/media/uploaded/files/2018/08/07/a83485c8-19f4-428c-b145-d271a16916f8__RANGER-2171_2.patch
> RANGER-2171_2.patch
>   https://reviews.apache.org/media/uploaded/files/2018/08/07/4897e7a7-d3c0-46c0-b223-92c26eda5060__RANGER-2171_2.patch
> RANGER-2171_2.patch
>   https://reviews.apache.org/media/uploaded/files/2018/08/07/81cec758-8870-4ebf-89f0-3f621a862dc9__RANGER-2171_2.patch
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message