ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ramesh Mani <rm...@hortonworks.com>
Subject Re: Review Request 68211: RANGER-2157 Add NiFi Registry service definition and NiFiRegistryClient
Date Tue, 07 Aug 2018 07:36:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/#review206932
-----------------------------------------------------------




plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
Lines 72 (patched)
<https://reviews.apache.org/r/68211/#comment290099>

    Intialize this connectivityStatus=true and make it false with error message where ever
condition permits
    
    you can do something like 
    
    if (Response.Status.OK.getStatusCode() != response.getStatus()) {
                    connectivityStatus = false;
                    errMsg = "Status Code = " + response.getStatus();
                }



plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
Lines 125 (patched)
<https://reviews.apache.org/r/68211/#comment290100>

    Can this context be null, please do the null check if so.



plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
Lines 180 (patched)
<https://reviews.apache.org/r/68211/#comment290102>

    Can this hostname be null?



plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
Lines 198 (patched)
<https://reviews.apache.org/r/68211/#comment290103>

    Move this as first statement in the method and return result instead of return new ArrayList<>();



plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java
Lines 64 (patched)
<https://reviews.apache.org/r/68211/#comment290104>

    if (LOG.isDebugEnabled()) {


- Ramesh Mani


On Aug. 7, 2018, 6:45 a.m., ijokarumawak@gmail.com Koji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68211/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 6:45 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2157
>     https://issues.apache.org/jira/browse/RANGER-2157
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
5e74da85a 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json
PRE-CREATION 
>   plugin-nifi-registry/.gitignore PRE-CREATION 
>   plugin-nifi-registry/pom.xml PRE-CREATION 
>   plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java
PRE-CREATION 
>   plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java
PRE-CREATION 
>   plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
PRE-CREATION 
>   plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java
PRE-CREATION 
>   plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java
PRE-CREATION 
>   plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java
PRE-CREATION 
>   plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java
PRE-CREATION 
>   plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION 
>   pom.xml 19a5e71b4 
>   src/main/assembly/admin-web.xml d0f354520 
> 
> 
> Diff: https://reviews.apache.org/r/68211/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on local machine.
> 
> In order to get NiFi Registry for integration tests, NiFi Registry needs to be built
manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry
Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do
so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md)
file should be a starting point.
> 
> 
> Thanks,
> 
> ijokarumawak@gmail.com Koji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message