ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 68076: RANGER-2165: Address JPA Cache issue when policies Create, Update and Delete are done via REST API in Apache Ranger admin
Date Tue, 31 Jul 2018 21:05:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68076/#review206680
-----------------------------------------------------------


Fix it, then Ship it!





agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java
Lines 61 (patched)
<https://reviews.apache.org/r/68076/#comment289760>

    Please check the intentation - here and the rest of the new code added in this commit.


- Madhan Neethiraj


On July 31, 2018, 2:42 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68076/
> -----------------------------------------------------------
> 
> (Updated July 31, 2018, 2:42 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani,
Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2165
>     https://issues.apache.org/jira/browse/RANGER-2165
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ensure that any entities cached in JPA layer during policy/tag cache refresh are cleared
when refresh is completed.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java e7e8cf519

>   security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java 463957c49

>   security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java 55505723d

>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 8efc950ce 
>   security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java 8341a7354 
> 
> 
> Diff: https://reviews.apache.org/r/68076/diff/2/
> 
> 
> Testing
> -------
> 
> Triggered policy/tag downloads from plugins. Ensured that policies/tags are correctly
retrieved and downloaded to plugins. Ensured that if policy cache is refreshed as part of
policy create/update, then any subsequent database interactions are completed in expected
time.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message