ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehul Parikh <mehul.par...@freestoneinfotech.com>
Subject Re: Review Request 67545: Good coding practices for REST classes and unit tests
Date Thu, 14 Jun 2018 13:44:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67545/#review204778
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On June 12, 2018, 2:04 p.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67545/
> -----------------------------------------------------------
> 
> (Updated June 12, 2018, 2:04 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2133
>     https://issues.apache.org/jira/browse/RANGER-2133
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good coding practices for REST classes and unit tests
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java c206acb 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java 529fd5b 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java
f4ea957 
> 
> 
> Diff: https://reviews.apache.org/r/67545/diff/1/
> 
> 
> Testing
> -------
> 
> tested on local machine.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message