ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <zsom...@apache.org>
Subject Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package
Date Tue, 12 Jun 2018 10:57:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/#review204596
-----------------------------------------------------------




security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java
Lines 126 (patched)
<https://reviews.apache.org/r/67544/#comment287175>

    This looks suspicious, is it testing the getPropertyStringList method? If yes, this actualroles
= roles will override the result.
    
    You can set the values with 'PropertiesUtil.getPropertiesMap().put(...)'


- Zsombor Gegesy


On June 12, 2018, 10:33 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67544/
> -----------------------------------------------------------
> 
> (Updated June 12, 2018, 10:33 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and
Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2132
>     https://issues.apache.org/jira/browse/RANGER-2132
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add unit tests for org.apache.ranger.common package
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
>   security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION

>   security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
>   security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
>   security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19

>   security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/67544/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with below two type
> 
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message