ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 67507: Improve ranger coverage of unit tests for REST layer.
Date Fri, 08 Jun 2018 16:15:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67507/#review204490
-----------------------------------------------------------




security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java
Lines 452 (patched)
<https://reviews.apache.org/r/67507/#comment286968>

    Please fix the PMD violation.
    
    ```
    [INFO] <<< maven-pmd-plugin:3.7:check (default) < :pmd @ security-admin-web
<<<
    [INFO]
    [INFO] --- maven-pmd-plugin:3.7:check (default) @ security-admin-web ---
    [INFO] PMD Failure: org.apache.ranger.rest.TestServiceREST:452 Rule:UnusedLocalVariable
Priority:3 Avoid unused local variables such as 'requestfd'..
    ```


- Velmurugan Periasamy


On June 8, 2018, 1:40 p.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67507/
> -----------------------------------------------------------
> 
> (Updated June 8, 2018, 1:40 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2126
>     https://issues.apache.org/jira/browse/RANGER-2126
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Improve ranger coverage of unit tests for REST layer.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java df0a927 
> 
> 
> Diff: https://reviews.apache.org/r/67507/diff/1/
> 
> 
> Testing
> -------
> 
> Checked if unit tests run properly.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message