ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daniel voros <daniel.vo...@gmail.com>
Subject Review Request 67475: Different error msg on backend/frontend login validation
Date Wed, 06 Jun 2018 13:10:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67475/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2123
    https://issues.apache.org/jira/browse/RANGER-2123


Repository: ranger


Description
-------

Leaving the pass empty will result in a JS error, while a wrong password will get the server
response:
```
The username or password you entered is incorrect..
```
vs
```
The username or password you entered is incorrect...
```
Lets go with a single '.' in both cases!


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java
35d75438f 
  security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc 


Diff: https://reviews.apache.org/r/67475/diff/1/


Testing
-------


Thanks,

daniel voros


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message