ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 67438: RANGER-2108: Ensure that resource names in service definition contain only lowercase, hyphens or underscore characters
Date Tue, 05 Jun 2018 00:04:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67438/
-----------------------------------------------------------

(Updated June 5, 2018, 12:04 a.m.)


Review request for ranger, Ramesh Mani and Velmurugan Periasamy.


Changes
-------

Addressed review comment


Bugs: RANGER-2108
    https://issues.apache.org/jira/browse/RANGER-2108


Repository: ranger


Description
-------

This is an update to an earlier commit (https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=commit;h=268512adc3170bb7799c29e3c5aa064750b9e9e7)
for the same issue. There may be existing service-defs which have mixed case access-type names,
and resource-names containing hyphens/underscore characters. This patch handles such cases.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java fbe3030c6

  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java
3f9315a7e 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
bdac64019 
  agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java
1fafb12fb 


Diff: https://reviews.apache.org/r/67438/diff/2/

Changes: https://reviews.apache.org/r/67438/diff/1-2/


Testing
-------

Updated unit test cases, ran all unit tests successfully.


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message