ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gautam Borad <gbo...@gmail.com>
Subject Re: Review Request 67434: RANGER-2119: Ranger UI: resource field issue when we set lookupSupported attribute to false in ranger-service-def.
Date Mon, 04 Jun 2018 13:21:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67434/#review204250
-----------------------------------------------------------


Ship it!




Ship It!

- Gautam Borad


On June 4, 2018, 1:01 p.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67434/
> -----------------------------------------------------------
> 
> (Updated June 4, 2018, 1:01 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan
Periasamy.
> 
> 
> Bugs: RANGER-2119
>     https://issues.apache.org/jira/browse/RANGER-2119
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1. If a resource-def's resource is defined with “lookupSupported” as false, then
the policy editor does not show multiple values separated by space (as seen in "lookupSupported"
as true).
> 2. policy screen resource field showing plain text field unlike other resource fields
for eg. Hive Table/Database field (when it has lookupSupported: true)
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js a928470 
>   security-admin/src/main/webapp/scripts/modules/XAOverrides.js ecce373 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 5bec224 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js e431f0a 
> 
> 
> Diff: https://reviews.apache.org/r/67434/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Tested resource field showing option to add multiple values for resource who has lookupSupport
as false in service definition for that resource.
> 2. Tested policy CRUD by toggling lookupSupport attribute (true/false) for different
different resources.
> 3. Also verified all service definition's policy screen with default service def values.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message