From dev-return-18118-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Tue May 22 14:58:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 91423180679 for ; Tue, 22 May 2018 14:58:04 +0200 (CEST) Received: (qmail 79870 invoked by uid 500); 22 May 2018 12:58:03 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 79789 invoked by uid 99); 22 May 2018 12:58:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2018 12:58:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A9410C005C; Tue, 22 May 2018 12:58:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.142 X-Spam-Level: ** X-Spam-Status: No, score=2.142 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nyd8w0sQHRMy; Tue, 22 May 2018 12:58:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 23F7A5F23C; Tue, 22 May 2018 12:58:01 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9F96EE0100; Tue, 22 May 2018 12:58:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 2924FC40222; Tue, 22 May 2018 12:58:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6474153173968227505==" MIME-Version: 1.0 Subject: Review Request 67234: RANGER-2102: Popup, Date picker and Dropdown list of select field remains open on-click of a back button from browser. From: Dhaval Rajpara To: Velmurugan Periasamy , Nitin Galave , Mehul Parikh , Gautam Borad Cc: Dhaval Rajpara , ranger Date: Tue, 22 May 2018 12:57:59 -0000 Message-ID: <20180522125759.19046.70560@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Dhaval Rajpara X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67234/ X-Sender: Dhaval Rajpara Reply-To: Dhaval Rajpara X-ReviewRequest-Repository: ranger --===============6474153173968227505== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67234/ ----------------------------------------------------------- Review request for ranger, Gautam Borad, Mehul Parikh, Nitin Galave, and Velmurugan Periasamy. Bugs: RANGER-2102 https://issues.apache.org/jira/browse/RANGER-2102 Repository: ranger Description ------- It is reproduced in most of the case where modals/popups/dropdown list are used in the page. Few cases are mention below: 1) Click on policy validity period in policy create page and hit the back button of the browser, popup remains open. 2) Click any drop-down list throughout in Ranger UI and simply press back button of the browser, the drop-down list remains open. 3) Click on date-selector throughout in Ranger UI and press back button of the browser, date-selector remains open. Diffs ----- security-admin/src/main/webapp/scripts/utils/XAUtils.js cf33e18 security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 6038895 security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionCreate.js 0d1c92f security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4158309 security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 2e925a9 security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 118abf0 security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b55d57e security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js b463938 security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 54444fb security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 840374f Diff: https://reviews.apache.org/r/67234/diff/1/ Testing ------- 1) Tested that Popup gets closed on policy period page after user clicks on back button. 2) Tested that Dropdown gets closed on Ranger UI after user clicks on back button. 3) Tested that Datepicker gets closed on Ranger UI after user clicks on back button. Thanks, Dhaval Rajpara --===============6474153173968227505==--