ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <zsom...@apache.org>
Subject Re: Review Request 66950: RANGER-2096 - remove dead code
Date Wed, 09 May 2018 15:51:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66950/
-----------------------------------------------------------

(Updated May 9, 2018, 3:51 p.m.)


Review request for ranger.


Changes
-------

Patch rebased


Bugs: RANGER-2096
    https://issues.apache.org/jira/browse/RANGER-2096


Repository: ranger


Description
-------

There is unnecessary dead code in AbstractBaseResourceService.java, which stores the child
services in a service map, which is only called from RangerBizUtil.getVObject/getMObject methods,
which are only called from test method.

This can be removed safely.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 00bda59af 
  security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java
a64bb3048 
  security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 174f919a3 


Diff: https://reviews.apache.org/r/66950/diff/2/

Changes: https://reviews.apache.org/r/66950/diff/1-2/


Testing
-------

Tested locally, and on a cluster


Thanks,

Zsombor Gegesy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message