ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sailaja Polavarapu <spolavar...@hortonworks.com>
Subject Review Request 66698: RANGER-2073: Good coding practices for usersync, tagsync, ldap tool configuration
Date Wed, 18 Apr 2018 20:54:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66698/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep
Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2073
    https://issues.apache.org/jira/browse/RANGER-2073


Repository: ranger


Description
-------

Good coding practices for usersync, tagsync, ldap tool configuration. Also added "commons-logging"
dependency for ldapconfigcheck tool as it is required for running the tool.


Diffs
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 5f6079ed 
  ugsync/ldapconfigchecktool/ldapconfigcheck/pom.xml 38dd4aac 
  ugsync/ldapconfigchecktool/ldapconfigcheck/scripts/run.sh f3f7ac5c 
  ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/CommandLineOptions.java
384ca239 
  ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java
5a90b1cb 
  ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java
d428e755 
  ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java e9e356a4

  ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
b30b051c 


Diff: https://reviews.apache.org/r/66698/diff/1/


Testing
-------

1. Verified usersync configuration in both secure and non-secure clusters.
2. Verified ldapconfigcheck tool to always prompt for sample authentication user password.


Thanks,

Sailaja Polavarapu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message