ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 66661: RANGER-2030: Admin UI updates to support policy effective dates
Date Wed, 18 Apr 2018 01:46:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66661/#review201372
-----------------------------------------------------------



Please fix warning message.
Applying: RANGER-2030 : Difference view (Audit->Admin tab) support for policy validity
period fields
.git/rebase-apply/patch:315: trailing whitespace.
					this.collection.add({'attributeName':key, 'newValue':val.toString(),'previousValue':
oldResources[key],type : "Policy Resources"}); 
warning: 1 line adds whitespace errors.

- Qiang Zhang


On April 17, 2018, 11:35 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66661/
> -----------------------------------------------------------
> 
> (Updated April 17, 2018, 11:35 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal,
and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2030
>     https://issues.apache.org/jira/browse/RANGER-2030
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Audit>admin : Show difference view for policy validity period fields in more readable
format instead just showing json (UI improvement and done some clean).
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 5d929c1

>   security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 99e1778

>   security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html
901a1df 
>   security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html
d93fcdb 
>   security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html
3cbde7a 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html
97ad345 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html
75c1f64 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html
cac71d9 
>   security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html
eb37c0b 
>   security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html a943813

>   security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html
58b9efa 
> 
> 
> Diff: https://reviews.apache.org/r/66661/diff/1/
> 
> 
> Testing
> -------
> 
> Verified diff view for policy validity period.
> 1.By adding a new validity period while policy creation
> 2.By adding new row for validity period in existing policy.
> 3.By updating/deleting the details in the existing validitity period.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message