ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 66304: RANGER-2041 : Handle validations for passwords of admin accounts during ranger install.
Date Wed, 04 Apr 2018 05:36:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66304/#review200422
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java
Lines 149-151 (patched)
<https://reviews.apache.org/r/66304/#comment281186>

    The code does not check the length of the newPassword variable.


- Qiang Zhang


On April 3, 2018, 12:51 p.m., Fatima Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66304/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 12:51 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2041
>     https://issues.apache.org/jira/browse/RANGER-2041
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently, when Ranger is installed admin,keyadmin, rangerusersync, rangertagsync users
are seeded users and they are configurable during the install process. This task is to provide
a facility to add validations to the admin users password during ranger install.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/dba_script.py d5eaaf0 
>   security-admin/scripts/install.properties 8128678 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java
e7a4035 
> 
> 
> Diff: https://reviews.apache.org/r/66304/diff/1/
> 
> 
> Testing
> -------
> 
> Tested the validation for all password combinations.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message