From dev-return-17188-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Tue Mar 13 02:54:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8583618067B for ; Tue, 13 Mar 2018 02:54:03 +0100 (CET) Received: (qmail 93461 invoked by uid 500); 13 Mar 2018 01:54:02 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 93417 invoked by uid 99); 13 Mar 2018 01:54:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Mar 2018 01:54:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1323E1806BF for ; Tue, 13 Mar 2018 01:54:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Pvam3h59anLa for ; Tue, 13 Mar 2018 01:54:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0FA755F5C6 for ; Tue, 13 Mar 2018 01:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8242DE021E for ; Tue, 13 Mar 2018 01:54:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3A5DD21474 for ; Tue, 13 Mar 2018 01:54:00 +0000 (UTC) Date: Tue, 13 Mar 2018 01:54:00 +0000 (UTC) From: "Velmurugan Periasamy (JIRA)" To: dev@ranger.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (RANGER-1991) Fix problems detected by static code analysis MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/RANGER-1991?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 96385#comment-16396385 ]=20 Velmurugan Periasamy commented on RANGER-1991: ---------------------------------------------- Resolving this now. Filed https://issues.apache.org/jira/browse/RANGER-2016= =C2=A0to get the other fix into master.=C2=A0 > Fix problems detected by static code analysis > --------------------------------------------- > > Key: RANGER-1991 > URL: https://issues.apache.org/jira/browse/RANGER-1991 > Project: Ranger > Issue Type: Bug > Components: admin > Affects Versions: 0.7.1 > Reporter: Zsombor Gegesy > Assignee: Zsombor Gegesy > Priority: Blocker > Labels: code-cleanup, findbugs > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1991-Import-policy-failure-fix-caused-by= -stat.patch, RANGER-1991-fix.patch, RANGER-1991.patch > > > FindBugs/SpotBug detects a couple of problems with the code base: > * Incorrect class casting - in XXServiceDef.equals > * Unnecessary NPE checks - for variables which is known to be non-null (= for example, because in other places a method is called on that object). In= ServiceREST.java PublicAPIs.java, ServiceUtil.java and independently in XU= serMgr.java > * Collection.contains method call which is never true - in ServiceDBStor= e.validatePolicyItems for policyItem.getAccesses().contains("") - because g= etAccesses doesn't store String objects > * Making public partially initialized objects in HadoopConfigHolder.init= ResourceMap() > * Calling toString on array, which is not too readable > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)