From dev-return-17421-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Sat Mar 24 13:18:26 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7174718064F for ; Sat, 24 Mar 2018 13:18:25 +0100 (CET) Received: (qmail 54160 invoked by uid 500); 24 Mar 2018 12:18:24 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 54145 invoked by uid 99); 24 Mar 2018 12:18:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Mar 2018 12:18:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 67D37C0EBD; Sat, 24 Mar 2018 12:18:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OlOUpQePGF8z; Sat, 24 Mar 2018 12:18:22 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C29F45F126; Sat, 24 Mar 2018 12:18:21 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1C490E00E8; Sat, 24 Mar 2018 12:18:21 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B1297C4013B; Sat, 24 Mar 2018 12:18:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4403231765390693358==" MIME-Version: 1.0 Subject: Re: Review Request 66024: RANGER-2016 - fix the code cleanup From: Zsombor Gegesy To: Velmurugan Periasamy , Zsombor Gegesy , ranger Date: Sat, 24 Mar 2018 12:18:20 -0000 Message-ID: <20180324121820.2309.11836@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zsombor Gegesy X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66024/ X-Sender: Zsombor Gegesy References: <20180315081258.49978.70571@reviews-vm2.apache.org> In-Reply-To: <20180315081258.49978.70571@reviews-vm2.apache.org> Reply-To: Zsombor Gegesy X-ReviewRequest-Repository: ranger --===============4403231765390693358== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66024/ ----------------------------------------------------------- (Updated March 24, 2018, 12:18 p.m.) Review request for ranger. Changes ------- rebased changes Bugs: RANGER-2016 https://issues.apache.org/jira/browse/RANGER-2016 Repository: ranger Description ------- There is a code path, where a null is passed as a HttpServletRequest - to trigger 'searching with empty filter'. A simple fix is to introduce a getServicePolicies(serviceName,SearchFilter) method on ServiceREST class, so the HttpServletRequest is not needed anymore, and this method can be called freely. Diffs (updated) ----- security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java c2783dcf6 security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 3642252f1 Diff: https://reviews.apache.org/r/66024/diff/3/ Changes: https://reviews.apache.org/r/66024/diff/2-3/ Testing ------- Tested locally Thanks, Zsombor Gegesy --===============4403231765390693358==--