From dev-return-17298-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Sat Mar 17 00:08:22 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8CD48180608 for ; Sat, 17 Mar 2018 00:08:21 +0100 (CET) Received: (qmail 32834 invoked by uid 500); 16 Mar 2018 23:08:20 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 32819 invoked by uid 99); 16 Mar 2018 23:08:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2018 23:08:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 817421A02F2; Fri, 16 Mar 2018 23:08:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4HAFA9gD0qgT; Fri, 16 Mar 2018 23:08:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 377E75F477; Fri, 16 Mar 2018 23:08:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C78C9E00A6; Fri, 16 Mar 2018 23:08:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7AFF1C4059E; Fri, 16 Mar 2018 23:08:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2492606112368494274==" MIME-Version: 1.0 Subject: Re: Review Request 66106: Update Hbase plugin to handle default namespace From: Abhay Kulkarni To: Madhan Neethiraj Cc: Abhay Kulkarni , ranger Date: Fri, 16 Mar 2018 23:08:16 -0000 Message-ID: <20180316230816.31578.18355@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Abhay Kulkarni X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66106/ X-Sender: Abhay Kulkarni References: <20180315225524.49979.32363@reviews-vm2.apache.org> In-Reply-To: <20180315225524.49979.32363@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerHbaseResource.java Reply-To: Abhay Kulkarni X-ReviewRequest-Repository: ranger --===============2492606112368494274== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66106/ ----------------------------------------------------------- (Updated March 16, 2018, 11:08 p.m.) Review request for ranger and Madhan Neethiraj. Changes ------- Added Hbase specific resource class, added unit tests Bugs: RANGER-2026 https://issues.apache.org/jira/browse/RANGER-2026 Repository: ranger Description ------- HBase supports a "default" namespace in which Hbase tables are implicitly present when namespace is not explicitly specified. Ranger Hbase policies with table-resource specified with or without a "default" namespace qualifier should match if a table in default namespace is accessed with or without "default" namespace qualifier. Diffs (updated) ----- hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java 1349aef9e hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerHbaseResource.java PRE-CREATION hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 665640f07 hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java 9f0e5ac87 hbase-agent/src/test/resources/hbase-policies-tag.json 61728c800 hbase-agent/src/test/resources/policyengine/test_policyengine_hbase.json f563c2850 Diff: https://reviews.apache.org/r/66106/diff/2/ Changes: https://reviews.apache.org/r/66106/diff/1-2/ Testing ------- Passed all unit tests. Thanks, Abhay Kulkarni --===============2492606112368494274==--