From dev-return-17213-archive-asf-public=cust-asf.ponee.io@ranger.apache.org Wed Mar 14 07:31:26 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BB5F0180654 for ; Wed, 14 Mar 2018 07:31:25 +0100 (CET) Received: (qmail 16849 invoked by uid 500); 14 Mar 2018 06:31:24 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 16826 invoked by uid 99); 14 Mar 2018 06:31:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Mar 2018 06:31:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AA841C187D; Wed, 14 Mar 2018 06:31:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.34 X-Spam-Level: ** X-Spam-Status: No, score=2.34 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MW8YYFOR5Tf4; Wed, 14 Mar 2018 06:31:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 620A65F178; Wed, 14 Mar 2018 06:31:17 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 907EDE002F; Wed, 14 Mar 2018 06:31:16 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 61DD5C4038A; Wed, 14 Mar 2018 06:31:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4769440707157871627==" MIME-Version: 1.0 Subject: Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin From: Nikhil P To: Gautam Borad , Abhay Kulkarni , Ramesh Mani , Velmurugan Periasamy , Pradeep Agrawal , Sailaja Polavarapu , Selvamohan Neethiraj , Ankita Sinha , Madhan Neethiraj , Don Bosco Durai Cc: Zsombor Gegesy , ranger , Nikhil P Date: Wed, 14 Mar 2018 06:31:16 -0000 Message-ID: <20180314063116.14161.35644@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nikhil P X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65920/ X-Sender: Nikhil P References: <20180312101612.64119.17298@reviews-vm2.apache.org> In-Reply-To: <20180312101612.64119.17298@reviews-vm2.apache.org> Reply-To: Nikhil P X-ReviewRequest-Repository: ranger --===============4769440707157871627== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/ ----------------------------------------------------------- (Updated March 14, 2018, 12:01 p.m.) Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-2010 https://issues.apache.org/jira/browse/RANGER-2010 Repository: ranger Description ------- Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin. Diffs (updated) ----- agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 0d94edc tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 697c7cc tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java a1dc8f5 tagsync/src/main/resources/ranger-tagsync-site.xml 3542ae2 Diff: https://reviews.apache.org/r/65920/diff/5/ Changes: https://reviews.apache.org/r/65920/diff/4-5/ Testing ------- 1)verified if ranger tagsync works as expected. 2)verified if tagsync is not re-login for every notification if "ranger.tagsync.cookie.enabled" is set as true. File Attachments (updated) ---------------- 0003-RANGER-2010-Ranger-Tagsync-should-use-cookie-based-a.patch https://reviews.apache.org/media/uploaded/files/2018/03/12/3f7133ab-72f9-413e-997c-4d9265f88cdc__0003-RANGER-2010-Ranger-Tagsync-should-use-cookie-based-a.patch 0005-RANGER-2010-Ranger-Tagsync-should-use-cookie-based-a.patch https://reviews.apache.org/media/uploaded/files/2018/03/14/e8193a99-70e9-4124-b70a-bd9335665455__0005-RANGER-2010-Ranger-Tagsync-should-use-cookie-based-a.patch Thanks, Nikhil P --===============4769440707157871627==--