ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailaja Polavarapu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RANGER-2006) Fix problems detected by static code analysis in ranger usersync for ldap sync source
Date Wed, 14 Mar 2018 21:09:00 GMT

    [ https://issues.apache.org/jira/browse/RANGER-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399422#comment-16399422
] 

Sailaja Polavarapu commented on RANGER-2006:
--------------------------------------------

Ranger usersync uses DirContecxt API for ldap search and according to the documentation looks
like API already handles the escaping of special characters. 

[https://docs.oracle.com/javase/7/docs/api/javax/naming/directory/DirContext.html#search(javax.naming.Name,%20java.lang.String,%20javax.naming.directory.SearchControls)]

_"When a string-valued filter argument is substituted for a variable, the filter is interpreted
as if the string were given in place of the variable, with any characters having special significance
within filters (such as {{'*'}}) having been escaped according to the rules of RFC 2254."_ 

 

Hence proposing to revert the change.

> Fix problems detected by static code analysis in ranger usersync for ldap sync source
> -------------------------------------------------------------------------------------
>
>                 Key: RANGER-2006
>                 URL: https://issues.apache.org/jira/browse/RANGER-2006
>             Project: Ranger
>          Issue Type: Bug
>          Components: Ranger, usersync
>    Affects Versions: 0.7.1
>            Reporter: Sailaja Polavarapu
>            Assignee: Sailaja Polavarapu
>            Priority: Minor
>             Fix For: 1.0.0, master
>
>
> 1. *Overview* : The method goUpGroupHierarchyLdap() invokes a dynamically generated
LDAP filter with unvalidated input, which could allow an attacker to modify the statement's
meaning.
> In the file LdapDeltaUserGroupBuilder.java similar issues were on line numbers 913
> *Comments* : need to verify the search() parameters for validation
> 2. *Overview* : The method goUpGroupHierarchyLdap() invokes a dynamically generated
LDAP filter with unvalidated input, which could allow an attacker to modify the statement's
meaning.
> In the file LdapUserGroupBuilder.java similar issues were on line numbers 818
> *Comments* : need to verify the search() parameters for validation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message