ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 66079: RANGER-1808:Write unit test for RANGER-1672 kylin plugin
Date Tue, 27 Mar 2018 07:14:00 GMT


> On March 16, 2018, 3:29 p.m., Colm O hEigeartaigh wrote:
> > Minor quibble - avoid creating unnecessary variables, e.g.:
> > 
> > > ProjectInstance project = getProjectInstance(name);
> > > return project;
> > 
> > could simply be:
> > 
> > return getProjectInstance(name);
> > 
> > Same goes for:
> > 
> > > ProjectInstance project = ProjectInstance.create(name, owner, description,
overrideProps, realizationEntries,
> > 				models);
> > >		return project;
> 
> Qiang Zhang wrote:
>     OK, thanks.

Hi Colm, I modified and updated the patch according to your review. Thanks!


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66079/#review199325
-----------------------------------------------------------


On March 19, 2018, 3:32 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66079/
> -----------------------------------------------------------
> 
> (Updated March 19, 2018, 3:32 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam
Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat
Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1808
>     https://issues.apache.org/jira/browse/RANGER-1808
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Write unit test for RANGER-1672 kylin plugin
> 
> 
> Diffs
> -----
> 
>   plugin-kylin/pom.xml bfce4c1 
>   plugin-kylin/src/test/java/org/apache/ranger/authorization/kylin/authorizer/RangerAdminClientImpl.java
PRE-CREATION 
>   plugin-kylin/src/test/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizerTest.java
PRE-CREATION 
>   plugin-kylin/src/test/resources/applicationContext.xml PRE-CREATION 
>   plugin-kylin/src/test/resources/kylin-policies.json PRE-CREATION 
>   plugin-kylin/src/test/resources/kylin.properties PRE-CREATION 
>   plugin-kylin/src/test/resources/kylinSecurity.xml PRE-CREATION 
>   plugin-kylin/src/test/resources/log4j.properties PRE-CREATION 
>   plugin-kylin/src/test/resources/ranger-kylin-security.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66079/diff/2/
> 
> 
> Testing
> -------
> 
> Test
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message