ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <zsom...@apache.org>
Subject Re: Review Request 66024: RANGER-2016 - fix the code cleanup
Date Sat, 24 Mar 2018 12:18:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66024/
-----------------------------------------------------------

(Updated March 24, 2018, 12:18 p.m.)


Review request for ranger.


Changes
-------

rebased changes


Bugs: RANGER-2016
    https://issues.apache.org/jira/browse/RANGER-2016


Repository: ranger


Description
-------

There is a code path, where a null is passed as a HttpServletRequest - to trigger 'searching
with empty filter'.
A simple fix is to introduce a getServicePolicies(serviceName,SearchFilter) method on ServiceREST
class, so the HttpServletRequest is not needed anymore, and this method can be called freely.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java c2783dcf6 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 3642252f1 


Diff: https://reviews.apache.org/r/66024/diff/3/

Changes: https://reviews.apache.org/r/66024/diff/2-3/


Testing
-------

Tested locally


Thanks,

Zsombor Gegesy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message