ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ramesh Mani <rm...@hortonworks.com>
Subject Re: Review Request 66170: RANGER-2031: Good coding practice in Ranger recommended by static code analysis
Date Tue, 20 Mar 2018 05:45:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66170/#review199522
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On March 20, 2018, 4:19 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66170/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 4:19 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2031
>     https://issues.apache.org/jira/browse/RANGER-2031
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Fix code issues in Ranger recommended by static code analysis
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagForEval.java
524605d15 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerValidityRecurrence.java
4bff3eaab 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerValiditySchedule.java
8fe323181 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
4557b9f04 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerValidityScheduleEvaluator.java
8f996d11a 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 86b4e4309

> 
> 
> Diff: https://reviews.apache.org/r/66170/diff/1/
> 
> 
> Testing
> -------
> 
> Ran unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message