Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3A1B4200D61 for ; Tue, 19 Dec 2017 22:07:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 388A2160C1B; Tue, 19 Dec 2017 21:07:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7B00B160BFF for ; Tue, 19 Dec 2017 22:07:31 +0100 (CET) Received: (qmail 64377 invoked by uid 500); 19 Dec 2017 21:07:30 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 64366 invoked by uid 99); 19 Dec 2017 21:07:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Dec 2017 21:07:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D9F7C1A110E; Tue, 19 Dec 2017 21:07:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id JupHh2V5oVqK; Tue, 19 Dec 2017 21:07:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A678D5F39E; Tue, 19 Dec 2017 21:07:28 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 38764E09A5; Tue, 19 Dec 2017 21:07:28 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 347F0C405FD; Tue, 19 Dec 2017 21:07:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0489620086867778893==" MIME-Version: 1.0 Subject: Review Request 64723: Ranger tagsync should process ENTITY_CREATE notification, to support Atlas import feature From: Abhay Kulkarni To: Madhan Neethiraj Cc: Abhay Kulkarni , ranger Date: Tue, 19 Dec 2017 21:07:26 -0000 Message-ID: <20171219210726.54788.29892@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Abhay Kulkarni X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64723/ X-Sender: Abhay Kulkarni Reply-To: Abhay Kulkarni X-ReviewRequest-Repository: ranger archived-at: Tue, 19 Dec 2017 21:07:32 -0000 --===============0489620086867778893== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64723/ ----------------------------------------------------------- Review request for ranger and Madhan Neethiraj. Bugs: RANGER-1937 https://issues.apache.org/jira/browse/RANGER-1937 Repository: ranger Description ------- Currently Ranger tagsync ignores ENTITY_CREATE notifications from Atlas, as no tags would be associated with the newly created entity. However, when an entity is created in Atlas via import, tags could be associated with the entity. To not miss the tags associated with the entities, Ranger tagsync should be updated to process ENTITY_CREATE notifications as well. Diffs ----- tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java f42c908 Diff: https://reviews.apache.org/r/64723/diff/1/ Testing ------- Unit test run successful Thanks, Abhay Kulkarni --===============0489620086867778893==--