Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ranger.apache.org
Content-Type: multipart/alternative;
 boundary="===============4812992155485215467=="
MIME-Version: 1.0
Subject: Re: Review Request 64634: RANGER-1929:The ranger should support
 preview policy.
From: Colm O hEigeartaigh <coheigea@apache.org>
To: Gautam Borad <gborad@gmail.com>, Alok Lal <allal@ebay.com>,
 Ramesh Mani <rmani@hortonworks.com>,
 Velmurugan Periasamy <vperiasamy@hortonworks.com>,
 Colm O hEigeartaigh <coheigea@apache.org>,
 Selvamohan Neethiraj <sneethiraj@hortonworks.com>,
 Ankita Sinha <ankita.sinha@freestoneinfotech.com>,
 Madhan Neethiraj <madhan@apache.org>, Qiang Zhang <zhangqiang2@zte.com.cn>,
 Don Bosco Durai <bosco@apache.org>
Cc: pengjianhua <peng.jianhua@zte.com.cn>, ranger <dev@ranger.apache.org>
Date: Tue, 19 Dec 2017 11:14:19 -0000
Message-ID: <20171219111419.54715.31584@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Colm O hEigeartaigh <noreply@reviews.apache.org>
References: <20171219091613.54715.67820@reviews-vm2.apache.org>
In-Reply-To: <20171219091613.54715.67820@reviews-vm2.apache.org>
Reply-To: Colm O hEigeartaigh <coheigea@apache.org>
archived-at: Tue, 19 Dec 2017 11:14:27 -0000

--===============4812992155485215467==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194135
-----------------------------------------------------------


Looks good thanks, but please see Vel's comments on the JIRA.

- Colm O hEigeartaigh


On Dec. 19, 2017, 9:16 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2017, 9:16 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1929
>     https://issues.apache.org/jira/browse/RANGER-1929
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166 
>   security-admin/src/main/webapp/styles/xa.css 22eedf64 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64634/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


--===============4812992155485215467==--