Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ranger.apache.org
Content-Type: multipart/alternative;
 boundary="===============3538900250574146109=="
MIME-Version: 1.0
Subject: Re: Review Request 64365: RANGER-1916:Remove duplicate code and
 optimize code in AtlasClient.class
From: Qiang Zhang <zhangqiang2@zte.com.cn>
To: Gautam Borad <gborad@gmail.com>, Alok Lal <allal@ebay.com>,
 Ramesh Mani <rmani@hortonworks.com>,
 Velmurugan Periasamy <vperiasamy@hortonworks.com>,
 Colm O hEigeartaigh <coheigea@apache.org>,
 Selvamohan Neethiraj <sneethiraj@hortonworks.com>,
 Ankita Sinha <ankita.sinha@freestoneinfotech.com>,
 Madhan Neethiraj <madhan@apache.org>, Qiang Zhang <zhangqiang2@zte.com.cn>,
 Don Bosco Durai <bosco@apache.org>
Cc: pengjianhua <peng.jianhua@zte.com.cn>, ranger <dev@ranger.apache.org>
Date: Wed, 06 Dec 2017 19:31:59 -0000
Message-ID: <20171206193159.9320.92195@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Qiang Zhang <noreply@reviews.apache.org>
References: <20171206075327.9320.48328@reviews-vm2.apache.org>
In-Reply-To: <20171206075327.9320.48328@reviews-vm2.apache.org>
Reply-To: Qiang Zhang <zhangqiang2@zte.com.cn>
archived-at: Wed, 06 Dec 2017 19:32:05 -0000

--===============3538900250574146109==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64365/#review193030
-----------------------------------------------------------


Ship it!


Ship It!

- Qiang Zhang


On 十二月 6, 2017, 7:53 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64365/
> -----------------------------------------------------------
> 
> (Updated 十二月 6, 2017, 7:53 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1916
>     https://issues.apache.org/jira/browse/RANGER-1916
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Remove duplicate code and optimize code in AtlasClient.class
> The follow code
> “if (client != null)
> { client.destroy(); }
> ” 
> in connectionTestResource and connectionTestResource method has been declared and execute in the getResourceList method that called them ,so remove duplicate code,And change the code "AtlasClient AtlasClient = null;" to "AtlasClient atlasClient = null;"
> 
> 
> Diffs
> -----
> 
>   plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java 857df87 
> 
> 
> Diff: https://reviews.apache.org/r/64365/diff/1/
> 
> 
> Testing
> -------
> 
> Tested it.
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


--===============3538900250574146109==--