Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ranger.apache.org
Content-Type: multipart/alternative;
 boundary="===============0843665081077162636=="
MIME-Version: 1.0
Subject: Re: Review Request 64323: RANGER-1915:Optimize the code and keep the
 code style consistent in the RangerAdminRESTClient class
From: Qiang Zhang <zhangqiang2@zte.com.cn>
To: Gautam Borad <gborad@gmail.com>, Alok Lal <allal@ebay.com>,
 Ramesh Mani <rmani@hortonworks.com>,
 Velmurugan Periasamy <vperiasamy@hortonworks.com>,
 Colm O hEigeartaigh <coheigea@apache.org>,
 Selvamohan Neethiraj <sneethiraj@hortonworks.com>,
 Ankita Sinha <ankita.sinha@freestoneinfotech.com>,
 Madhan Neethiraj <madhan@apache.org>, Qiang Zhang <zhangqiang2@zte.com.cn>,
 Don Bosco Durai <bosco@apache.org>
Cc: pengjianhua <peng.jianhua@zte.com.cn>, ranger <dev@ranger.apache.org>
Date: Wed, 06 Dec 2017 02:40:01 -0000
Message-ID: <20171206024001.7812.6993@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Qiang Zhang <noreply@reviews.apache.org>
References: <20171205023945.13476.99555@reviews-vm2.apache.org>
In-Reply-To: <20171205023945.13476.99555@reviews-vm2.apache.org>
Reply-To: Qiang Zhang <zhangqiang2@zte.com.cn>
archived-at: Wed, 06 Dec 2017 02:40:11 -0000

--===============0843665081077162636==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64323/#review192964
-----------------------------------------------------------


Ship it!


Ship It!

- Qiang Zhang


On Dec. 5, 2017, 2:39 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64323/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 2:39 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1915
>     https://issues.apache.org/jira/browse/RANGER-1915
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Default constructors didn't need to display declarations and Most of the places using HttpServletResponse status code in RangerAdminRESTClient class.
> HttpServletResponse.SC_UNAUTHORIZED Replaces 401 to keep the code style consistent.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java 0aa400f 
> 
> 
> Diff: https://reviews.apache.org/r/64323/diff/1/
> 
> 
> Testing
> -------
> 
> Tested it.
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


--===============0843665081077162636==--