ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 64634: RANGER-1929:The ranger should support preview policy.
Date Tue, 19 Dec 2017 11:14:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194135
-----------------------------------------------------------



Looks good thanks, but please see Vel's comments on the JIRA.

- Colm O hEigeartaigh


On Dec. 19, 2017, 9:16 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2017, 9:16 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and
Qiang Zhang.
> 
> 
> Bugs: RANGER-1929
>     https://issues.apache.org/jira/browse/RANGER-1929
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently we can only edit the policy without previewing the policy. We must use editing
funtion of policy when only need to query the detail for policy. So we should supply the function
of the query detail for policy.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION

>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION

>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166

>   security-admin/src/main/webapp/styles/xa.css 22eedf64 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html
PRE-CREATION 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/64634/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message