ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 64622: Remove use of maven-shade-plugin from Ranger build scripts
Date Thu, 14 Dec 2017 21:59:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64622/
-----------------------------------------------------------

(Updated Dec. 14, 2017, 9:59 p.m.)


Review request for ranger, Madhan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Removed commons-logging dependency from ldapconfigcheck tool POM


Bugs: RANGER-1931
    https://issues.apache.org/jira/browse/RANGER-1931


Repository: ranger


Description
-------

Ranger does not need to use any shaded JARs. So, Ranger build scripts (POMs) should not use
maven-shade-plugin.

There are two places where shaded jars are used; hdfs-agent - because it shaded javassist.jar,
and ldapconfigchecktool - because it used an uber-jar to build a self-contained, executable
jar for config-check tool. Modifications are made to these to avoid using shaded libraries.


Diffs (updated)
-----

  hdfs-agent/pom.xml 7aec881 
  hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/agent/AuthCodeInjectionJavaAgent.java
065c8a5 
  hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/agent/HadoopAuthClassTransformer.java
7356cae 
  pom.xml 3086a1e 
  src/main/assembly/usersync.xml 8d21dd3 
  ugsync/ldapconfigchecktool/ldapconfigcheck/pom.xml 20960cc 


Diff: https://reviews.apache.org/r/64622/diff/2/

Changes: https://reviews.apache.org/r/64622/diff/1-2/


Testing
-------

Tested locally.


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message