ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 64525: RANGER-1924:Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml
Date Tue, 12 Dec 2017 18:20:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64525/#review193580
-----------------------------------------------------------



And also, you could remove the gson dependency from the hdfs-plugin pom.

- Colm O hEigeartaigh


On Dec. 12, 2017, 2:43 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64525/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 2:43 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and
Qiang Zhang.
> 
> 
> Bugs: RANGER-1924
>     https://issues.apache.org/jira/browse/RANGER-1924
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Simplify ranger-hdfs plugin remove gson.jar in ranger/src/main/assembly/hdfs-agent.xml

> Description:
> Remove <include>com.google.code.gson:gson*</include> in ranger/src/main/assembly/hdfs-agent.xml
> Reason:
> 1.Hadoop already has gson.jar removed from gson.jar to prevent conflicts 
> 2.Observing ranger-yarn plugin has also removed gson.jar in ranger/src/main/assembly/plugin-yarn.xml.
> Result: the ranger-hdfs plugin also works fine after removing gson.jar.
> 
> 
> Diffs
> -----
> 
>   src/main/assembly/hdfs-agent.xml 5279a9a 
> 
> 
> Diff: https://reviews.apache.org/r/64525/diff/1/
> 
> 
> Testing
> -------
> 
> Tested it.
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message