ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pengjianhua <peng.jian...@zte.com.cn>
Subject Review Request 64293: RANGER-1914:Modify crypt_algo_array.length to avoid java.lang.ArrayIndexOutOfBoundsException in PasswordUtils.class
Date Mon, 04 Dec 2017 08:30:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64293/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam
Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang
Zhang.


Bugs: RANGER-1914
    https://issues.apache.org/jira/browse/RANGER-1914


Repository: ranger


Description
-------

Code: if (crypt_algo_array != null && crypt_algo_array.length > 1)
 when crypt_algo_array.length<5   password = crypt_algo_array[4]; will case java.lang.ArrayIndexOutOfBoundsException.
 Change from "if (crypt_algo_array != null && crypt_algo_array.length > 1)"  to
"if (crypt_algo_array != null && crypt_algo_array.length > 4)".


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 58cdd35 


Diff: https://reviews.apache.org/r/64293/diff/1/


Testing
-------

Tested it.


Thanks,

pengjianhua


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message