Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 22E24200D56 for ; Mon, 27 Nov 2017 23:27:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 20EF1160BFA; Mon, 27 Nov 2017 22:27:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6BBAD160C13 for ; Mon, 27 Nov 2017 23:27:05 +0100 (CET) Received: (qmail 9950 invoked by uid 500); 27 Nov 2017 22:27:04 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 9617 invoked by uid 99); 27 Nov 2017 22:27:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Nov 2017 22:27:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 78E591A02B6; Mon, 27 Nov 2017 22:27:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DJgbwKp-I4AE; Mon, 27 Nov 2017 22:27:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B03595F244; Mon, 27 Nov 2017 22:27:01 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7B055E0161; Mon, 27 Nov 2017 22:27:01 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D3845C403A9; Mon, 27 Nov 2017 22:27:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5586633998506604143==" MIME-Version: 1.0 Subject: Re: Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST From: Alejandro Fernandez To: Abhay Kulkarni Cc: Madhan Neethiraj , Alejandro Fernandez , ranger Date: Mon, 27 Nov 2017 22:27:00 -0000 Message-ID: <20171127222700.9185.21423@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alejandro Fernandez X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64042/ X-Sender: Alejandro Fernandez References: <20171125204349.43341.78531@reviews-vm2.apache.org> In-Reply-To: <20171125204349.43341.78531@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java Reply-To: Alejandro Fernandez X-ReviewRequest-Repository: ranger archived-at: Mon, 27 Nov 2017 22:27:06 -0000 --===============5586633998506604143== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64042/#review191941 ----------------------------------------------------------- tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java Line 40 (original), 49 (patched) Suggest expanding this import tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java Lines 180 (patched) Make ATLAS_ENTITIES a constant tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java Line 175 (original), 173 (patched) Add JavaDoc - Alejandro Fernandez On Nov. 25, 2017, 8:43 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64042/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2017, 8:43 p.m.) > > > Review request for ranger and Abhay Kulkarni. > > > Bugs: RANGER-1897 > https://issues.apache.org/jira/browse/RANGER-1897 > > > Repository: ranger > > > Description > ------- > > Updated tag-sync to use Atlas V2 REST APIs to download tags, instead of using V1 APIs. This significantly reduces the number of REST API calls from tag-sync to Atlas and will result in a better performance. > > > Diffs > ----- > > pom.xml 80de97e8 > src/main/assembly/tagsync.xml 0b17151b > tagsync/pom.xml 42e9d2ff > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHbaseResourceMapper.java 8b36a318 > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHdfsResourceMapper.java 06bff906 > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHiveResourceMapper.java a3596223 > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java 9f1fc2db > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java 922317e8 > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapper.java 8ececdf7 > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java f9f0eafd > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java 12b02d94 > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 4e0ae908 > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java 00a101e7 > > > Diff: https://reviews.apache.org/r/64042/diff/4/ > > > Testing > ------- > > Verified that tags successfully download with Atlas V2 REST APIs. > > > Thanks, > > Madhan Neethiraj > > --===============5586633998506604143==--