Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ranger.apache.org
Content-Type: multipart/alternative;
 boundary="===============2367346431348129605=="
MIME-Version: 1.0
Subject: Review Request 63657: The ranger policies json file should be
 formatted when exported at ranger service manager.
From: wang yuan <wang.yuan17@zte.com.cn>
To: Gautam Borad <gborad@gmail.com>, Alok Lal <allal@ebay.com>,
 Ramesh Mani <rmani@hortonworks.com>,
 Velmurugan Periasamy <vperiasamy@hortonworks.com>,
 pengjianhua <peng.jianhua@zte.com.cn>,
 Colm O hEigeartaigh <coheigea@apache.org>,
 Selvamohan Neethiraj <sneethiraj@hortonworks.com>,
 Ankita Sinha <ankita.sinha@freestoneinfotech.com>,
 Madhan Neethiraj <madhan@apache.org>, Qiang Zhang <zhangqiang2@zte.com.cn>,
 Don Bosco Durai <bosco@apache.org>
Cc: ranger <dev@ranger.apache.org>, wang yuan <wang.yuan17@zte.com.cn>
Date: Wed, 08 Nov 2017 06:31:00 -0000
Message-ID: <20171108063100.35837.34967@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: wang yuan <noreply@reviews.apache.org>
Reply-To: wang yuan <wang.yuan17@zte.com.cn>
archived-at: Wed, 08 Nov 2017 06:55:27 -0000

--===============2367346431348129605==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63657/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1877
    https://issues.apache.org/jira/browse/RANGER-1877


Repository: ranger


Description
-------

The ranger policies json file should be formatted when exported  at ranger service manager. 
I found  it's difficult to edit the unformatted json file.

{code:title=ServiceDBStore.java|borderStyle=solid}
private void writeJson(List<RangerPolicy> policies, String jsonFileName,
			HttpServletResponse response) throws JSONException, IOException {
		... ...
		//Gson gson = new Gson();      //shoud be replaced:
                Gson gson = new GsonBuilder().setPrettyPrinting().create();
		
                String json = gson.toJson(rangerExportPolicyList, RangerExportPolicyList.class);
                ... ...
{code}


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 195510dc 


Diff: https://reviews.apache.org/r/63657/diff/1/


Testing
-------


Thanks,

wang yuan


--===============2367346431348129605==--