Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 54F5B200D41 for ; Wed, 8 Nov 2017 04:38:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 538AC160C01; Wed, 8 Nov 2017 03:38:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A1BF7160BED for ; Wed, 8 Nov 2017 04:37:59 +0100 (CET) Received: (qmail 56570 invoked by uid 500); 8 Nov 2017 03:37:58 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 56551 invoked by uid 99); 8 Nov 2017 03:37:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 03:37:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 96E711A2AFE; Wed, 8 Nov 2017 03:37:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.2 X-Spam-Level: *** X-Spam-Status: No, score=3.2 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DYmmjBQPpOd6; Wed, 8 Nov 2017 03:37:56 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0890F67F36; Wed, 8 Nov 2017 02:27:16 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4D3FFE00B3; Wed, 8 Nov 2017 02:27:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 422CDC40659; Wed, 8 Nov 2017 02:27:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4550224521658791306==" MIME-Version: 1.0 Subject: Re: Review Request 63608: RANGER-1830:Write unit test for RANGER-1810 sqoop plugin From: Qiang Zhang To: Gautam Borad , Venkat Ranganathan , pengjianhua , Ramesh Mani , Velmurugan Periasamy , sam rome , Colm O hEigeartaigh , Selvamohan Neethiraj , Ankita Sinha , Madhan Neethiraj , Don Bosco Durai Cc: Qiang Zhang , ranger Date: Wed, 08 Nov 2017 02:27:15 -0000 Message-ID: <20171108022715.26135.77582@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qiang Zhang X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63608/ X-Sender: Qiang Zhang References: <20171107065630.26136.31072@reviews-vm2.apache.org> In-Reply-To: <20171107065630.26136.31072@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerAdminClientImpl.java X-ReviewBoard-Diff-For: plugin-sqoop/src/test/resources/sqoop_bootstrap.properties X-ReviewBoard-Diff-For: plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerSqoopAuthorizerTest.java X-ReviewBoard-Diff-For: plugin-sqoop/src/test/resources/log4j.properties X-ReviewBoard-Diff-For: plugin-sqoop/src/test/resources/ranger-sqoop-security.xml X-ReviewBoard-Diff-For: plugin-sqoop/src/test/resources/sqoop.properties X-ReviewBoard-Diff-For: plugin-sqoop/src/test/resources/sqoop-policies.json Reply-To: Qiang Zhang X-ReviewRequest-Repository: ranger archived-at: Wed, 08 Nov 2017 03:38:00 -0000 --===============4550224521658791306== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63608/ ----------------------------------------------------------- (Updated εδΈ€ζœˆ 8, 2017, 2:27 a.m.) Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy. Changes ------- Change Summary: a) Optimization getRandomLinkName and getRandomJobName; b) Change new ArrayList() to new ArrayList<>(); Bugs: RANGER-1830 https://issues.apache.org/jira/browse/RANGER-1830 Repository: ranger Description ------- Write unit test for RANGER-1810 sqoop plugin Diffs (updated) ----- plugin-sqoop/pom.xml 0c52e66 plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerAdminClientImpl.java PRE-CREATION plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerSqoopAuthorizerTest.java PRE-CREATION plugin-sqoop/src/test/resources/log4j.properties PRE-CREATION plugin-sqoop/src/test/resources/ranger-sqoop-security.xml PRE-CREATION plugin-sqoop/src/test/resources/sqoop-policies.json PRE-CREATION plugin-sqoop/src/test/resources/sqoop.properties PRE-CREATION plugin-sqoop/src/test/resources/sqoop_bootstrap.properties PRE-CREATION Diff: https://reviews.apache.org/r/63608/diff/2/ Changes: https://reviews.apache.org/r/63608/diff/1-2/ Testing ------- Tested Thanks, Qiang Zhang --===============4550224521658791306==--