Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A3943200D36 for ; Mon, 6 Nov 2017 11:31:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A2287160BEC; Mon, 6 Nov 2017 10:31:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E696F1609E0 for ; Mon, 6 Nov 2017 11:31:55 +0100 (CET) Received: (qmail 43341 invoked by uid 500); 6 Nov 2017 10:31:55 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 43324 invoked by uid 99); 6 Nov 2017 10:31:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Nov 2017 10:31:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 10AA41A1C0B; Mon, 6 Nov 2017 10:31:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id oFy10DMWyKSO; Mon, 6 Nov 2017 10:31:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 26A72630AA; Mon, 6 Nov 2017 10:22:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7B543E0A3A; Mon, 6 Nov 2017 10:22:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 73E87C4111E; Mon, 6 Nov 2017 10:22:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5244399714673880580==" MIME-Version: 1.0 Subject: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB From: Zsombor Gegesy To: Zsombor Gegesy , ranger Date: Mon, 06 Nov 2017 10:22:22 -0000 Message-ID: <20171106102222.31729.46091@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zsombor Gegesy X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63575/ X-Sender: Zsombor Gegesy Reply-To: Zsombor Gegesy X-ReviewRequest-Repository: ranger archived-at: Mon, 06 Nov 2017 10:31:56 -0000 --===============5244399714673880580== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63575/ ----------------------------------------------------------- Review request for ranger. Bugs: RANGER-1873 https://issues.apache.org/jira/browse/RANGER-1873 Repository: ranger Description ------- In RangerKMSDB, the updateDBSSLURL function is never called, because getDBFlavor always return DB_FLAVOR_UNKNOWN, because it tries to read from DB_PROPERTIES, instead of the configuration. The DB_PROPERTIES only contains - at that point values for the keys: PROPERTY_PREFIX+DB_DIALECT,PROPERTY_PREFIX+DB_DRIVER,PROPERTY_PREFIX+DB_URL. Fixed this issue, moved the DB_PROPERTIES static variable to an instance variable, and simplified the string manipulation code a bit Diffs ----- kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java 649da30c5 Diff: https://reviews.apache.org/r/63575/diff/1/ Testing ------- https://travis-ci.org/gzsombor/ranger/builds/297898874 Thanks, Zsombor Gegesy --===============5244399714673880580==--