ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <gzsom...@gmail.com>
Subject Re: Review Request 63987: RANGER-1905 : fix maven assembly creation
Date Mon, 27 Nov 2017 14:40:27 GMT


> On Nov. 23, 2017, 11:44 a.m., Colm O hEigeartaigh wrote:
> > How can I reproduce the error as reported on the JIRA? I unzipped the Ranger admin
+ installed and started it without any errors in the logs.

In this commit https://github.com/apache/ranger/commit/8dc5598c034017a22bacf9e6082aa1f4a7d6cc23
the ./cred/lib folder was added to the classpath, which hides this issue. But I think, that's
not the best solution, it would be better if the 'ews' library patch, and the 'cred' library
path could stay separated.


- Zsombor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63987/#review191793
-----------------------------------------------------------


On Nov. 22, 2017, 12:23 p.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63987/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 12:23 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1905
>     https://issues.apache.org/jira/browse/RANGER-1905
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> As ranger-plugins-audit doesn't exclude guava from hadoop common, an older guava
>  is leaked into embeddedwebserver classpath, which somehow filtered out by the
>  assembly plugin.
> If we explicitly exclude the old guava, and include the new (17.0) guava in ranger-plugins-audit
module, the generated tar.gz/zip distributions will contain the necessary guava-17.0.jar in
ews/lib path.
> 
> 
> Diffs
> -----
> 
>   agents-audit/pom.xml c8bd1d8f3 
>   src/main/assembly/plugin-atlas.xml fd988116d 
> 
> 
> Diff: https://reviews.apache.org/r/63987/diff/2/
> 
> 
> Testing
> -------
> 
> Tested with executing:
> 
> mvn -DskipTests package assembly:assembly;
> unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt
> 
> And comparing the results with different versions. With the patch, the guava jar appears
correctly.
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message