ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <gzsom...@gmail.com>
Subject Re: Review Request 63987: RANGER-1905 : fix maven assembly creation
Date Wed, 22 Nov 2017 12:23:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63987/
-----------------------------------------------------------

(Updated Nov. 22, 2017, 12:23 p.m.)


Review request for ranger.


Changes
-------

Changing the include/filter logic for the atlas plugin - now we add all the dependencies of
org.apache.ranger:ranger-atlas-plugin, with a wider filter, so the old guava jar appears,
instead of adding all the dependencies of the plugin + ranger-plugins-audit + etc, which forced
the newer guava to appear - but instantly filtered out.


Bugs: RANGER-1905
    https://issues.apache.org/jira/browse/RANGER-1905


Repository: ranger


Description
-------

As ranger-plugins-audit doesn't exclude guava from hadoop common, an older guava
 is leaked into embeddedwebserver classpath, which somehow filtered out by the
 assembly plugin.
If we explicitly exclude the old guava, and include the new (17.0) guava in ranger-plugins-audit
module, the generated tar.gz/zip distributions will contain the necessary guava-17.0.jar in
ews/lib path.


Diffs (updated)
-----

  agents-audit/pom.xml c8bd1d8f3 
  src/main/assembly/plugin-atlas.xml fd988116d 


Diff: https://reviews.apache.org/r/63987/diff/2/

Changes: https://reviews.apache.org/r/63987/diff/1-2/


Testing
-------

Tested with executing:

mvn -DskipTests package assembly:assembly;
unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt

And comparing the results with different versions. With the patch, the guava jar appears correctly.


Thanks,

Zsombor Gegesy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message