ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 64022: The permission of "Kafka Admin" can not support "Select/Deselect All" when add/edit Kafka policy
Date Wed, 22 Nov 2017 08:51:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64022/
-----------------------------------------------------------

(Updated Nov. 22, 2017, 8:51 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam
Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy,
and Qiang Zhang.


Bugs: RANGER_1890
    https://issues.apache.org/jira/browse/RANGER_1890


Repository: ranger


Description (updated)
-------

The current logic is as following:
1. Other checkbox will not be selected when the "Kafka Admin" was selected.
2. Other checkbox will not be deselected when the "Kafka Admin“ checkbox" was deselected.
The right logic should be as following:
1. Other checkbox will be selected when the "Kafka Admin" was selected.
2. Other checkbox will be deselected when the "Kafka Admin" was deselected.
3. When all Other checkboxes are selected, cancel one of them, the "Kafka Admin" checkbox
will be canceled.


Diffs
-----

  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js df6a2be3 


Diff: https://reviews.apache.org/r/64022/diff/1/


Testing (updated)
-------

I had carefully tested the issue.


Thanks,

Qiang Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message