ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <gzsom...@gmail.com>
Subject Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB
Date Mon, 06 Nov 2017 10:22:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63575/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1873
    https://issues.apache.org/jira/browse/RANGER-1873


Repository: ranger


Description
-------

In RangerKMSDB, the updateDBSSLURL function is never called, because getDBFlavor always return
DB_FLAVOR_UNKNOWN, because it tries to read from DB_PROPERTIES, instead of the configuration.
The DB_PROPERTIES only contains - at that point values for the keys: PROPERTY_PREFIX+DB_DIALECT,PROPERTY_PREFIX+DB_DRIVER,PROPERTY_PREFIX+DB_URL.

Fixed this issue, moved the DB_PROPERTIES static variable to an instance variable, and simplified
the string manipulation code a bit


Diffs
-----

  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java 649da30c5 


Diff: https://reviews.apache.org/r/63575/diff/1/


Testing
-------

https://travis-ci.org/gzsombor/ranger/builds/297898874


Thanks,

Zsombor Gegesy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message