quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #350: Fixed the bug regarding EliminateEmpt...
Date Fri, 04 May 2018 18:09:43 GMT
GitHub user zuyu opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/350

    Fixed the bug regarding EliminateEmptyNode and InsertSelection.

    This PR fixed a bug regarding `EliminateEmptyNode` and `InsertSelection` that could be
easily reproduced as the following:
    ```
    CREATE TABLE temp (a int);
    \analyze
    INSERT INTO temp SELECT i FROM generate_series(1, 100) AS gs(i);
    ```
    
    The problem is that `InsertSelection` allows the destination table to be empty, but the
rule does not catch that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zuyu/incubator-quickstep elimination-rule-bug-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #350
    
----
commit 77287a78890284139273dd5344e7d9b141f7ee25
Author: Zuyu Zhang <zuyu@...>
Date:   2018-05-04T18:04:02Z

    Fixed the bug regarding EliminateEmptyNode and InsertSelection.

----


---

Mime
View raw message