quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #347: QUICKSTEP-121: Added the self-join support.
Date Wed, 09 May 2018 23:09:58 GMT
Github user jianqiao commented on the issue:

    LGTM! Merging.
    Note that the `concretize` signature in `Physical` plans looks somehow cumbersome, we
may add a `SubstitutionContext` class to wrap these in a future PR.
    ::quickstep::Predicate* concretize(
        const std::unordered_map<ExprId, const CatalogAttribute*> &substitution_map,
        const std::unordered_set<ExprId> &left_expr_ids = std::unordered_set<ExprId>(),
        const std::unordered_set<ExprId> &right_expr_ids = std::unordered_set<ExprId>())
const override;


View raw message