quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #346: Add a python script to auto fix CMake...
Date Sat, 28 Apr 2018 02:00:32 GMT
GitHub user jianqiao opened a pull request:


    Add a python script to auto fix CMakeLists files

    This PR adds a script that intends to help improve developer productivity by automatically
fixing `CMakeLists.txt` files for the Quickstep project (with best effort).
    The script will do the following things:
    - Scan the repo's subdirectories and collect `#include` information from all source code
    - Parse existing `CMakeLists.txt` files and convert all "recognized" commands into proper
intermediate representations -- the "unrecognized" part will be kept as "verbal" lines.
    - Resolve subdirectories, targets and link dependencies. Add / delete / update the corresponding
    - Convert the intermediate representations back to `CMakeLists.txt` files.
    **NOTE:** Currently the script is at its initial stage and will not update tests or conditional
targets (i.e. those within cmake `if` commands). It is likely to work well if you just create/delete
some files or add/remove some `#include`'s -- otherwise additional manual fixes may need to
be done after applying the script.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jianqiao/incubator-quickstep autofix-cmake-tool

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #346
commit 73d796dee760a03a91d55cb0fe4d8f073f831237
Author: Jianqiao Zhu <jianqiao@...>
Date:   2018-04-27T22:28:51Z

    Add a python script to auto fix CMakeLists files



View raw message