quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #325: DO NOT MERGE: Concurrent queries tran...
Date Fri, 24 Nov 2017 19:32:46 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/325#discussion_r153019502
  
    --- Diff: query_optimizer/QueryHandle.hpp ---
    @@ -178,6 +178,14 @@ class QueryHandle {
         query_result_relation_ = relation;
       }
     
    +  /**
    +   * @brief Return all the base relations referenced in this query.
    +   **/
    +  std::vector<relation_id> getAllReferencedBaseRelations() {
    --- End diff --
    
    This should mark as a `const` method, and I think we need to add a data member called
`referenced_base_relations_`.


---

Mime
View raw message