Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7143D200D24 for ; Mon, 9 Oct 2017 20:23:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6FBB11609B8; Mon, 9 Oct 2017 18:23:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6E151609CE for ; Mon, 9 Oct 2017 20:23:56 +0200 (CEST) Received: (qmail 11027 invoked by uid 500); 9 Oct 2017 18:23:55 -0000 Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@quickstep.incubator.apache.org Delivered-To: mailing list dev@quickstep.incubator.apache.org Received: (qmail 11013 invoked by uid 99); 9 Oct 2017 18:23:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Oct 2017 18:23:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id ADACB1A2185 for ; Mon, 9 Oct 2017 18:23:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id fXFjcFph5r4c for ; Mon, 9 Oct 2017 18:23:53 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 295D860D31 for ; Mon, 9 Oct 2017 18:23:52 +0000 (UTC) Received: (qmail 10946 invoked by uid 99); 9 Oct 2017 18:23:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Oct 2017 18:23:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9A037F5C39; Mon, 9 Oct 2017 18:23:51 +0000 (UTC) From: zuyu To: dev@quickstep.incubator.apache.org Reply-To: dev@quickstep.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-quickstep pull request #309: Add ProbabilityStore class Content-Type: text/plain Message-Id: <20171009182351.9A037F5C39@git1-us-west.apache.org> Date: Mon, 9 Oct 2017 18:23:51 +0000 (UTC) archived-at: Mon, 09 Oct 2017 18:23:57 -0000 Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/309#discussion_r143522173 --- Diff: query_execution/ProbabilityStore.hpp --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + **/ + +#ifndef QUICKSTEP_QUERY_EXECUTION_PROBABILITY_STORE_HPP_ +#define QUICKSTEP_QUERY_EXECUTION_PROBABILITY_STORE_HPP_ + +#include +#include +#include +#include +#include + +#include "utility/Macros.hpp" + +#include "glog/logging.h" + +namespace quickstep { + +/** + * @brief A class that stores the probabilities of objects. We use an integer field + * called "key" to identify each object. + * A probability is expressed as a fraction. All the objects share a common denominator. + **/ +class ProbabilityStore { + public: + /** + * @brief Constructor. + **/ + ProbabilityStore() + : common_denominator_(1.0) {} + + /** + * @brief Get the number of objects in the store. + **/ + inline const std::size_t getNumObjects() const { + DCHECK_EQ(individual_probabilities_.size(), cumulative_probabilities_.size()); --- End diff -- Does it follow the rule that the left side is the checked variable, and the right is the expected one? ---