quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #308: Removed unused argument always_mark_f...
Date Tue, 10 Oct 2017 19:12:18 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/308#discussion_r143825045
  
    --- Diff: storage/InsertDestinationInterface.hpp ---
    @@ -104,7 +104,7 @@ class InsertDestinationInterface {
        *        insertion from ValueAccessor even when partially full.
        **/
       virtual void bulkInsertTuples(ValueAccessor *accessor,
    -                                bool always_mark_full = false) = 0;
    +                                const bool always_mark_full = false) = 0;
    --- End diff --
    
    It is required by the first pass of the multi-pass sort.


---

Mime
View raw message